[TIMOB-24967] Android: Update to support library 26.0.1 #9274

garymathews · 2017-08-03T18:43:47Z

Update to support library ~~26.0.0~~ 26.0.1
~~Target android-26 by default~~
Build using android-26
Include IntelliJ and Android Studio project files

garymathews · 2017-08-04T14:17:43Z

Wait for Jenkins to update to android-26

jquick-axway · 2017-08-04T22:42:28Z

@garymathews, let's not target API Level 26 (aka: Android O) yet.

Before we can target API Level 26, we need to resolve any breaking changes it'll cause first. I'm especially concerned about the changes mentioned under Networking, Security, and Privacy.
https://developer.android.com/preview/behavior-changes.html

However, we should allow the developer to target API Level 26 if they want to via the "tiapp.xml" (they can do so at their own risk). I'm just saying we shouldn't default to it yet.

garymathews · 2017-08-08T13:10:57Z

@jquick-axway But we need to target it to access Android O specific features that we are aiming to support, and targeting it will also let us verify what is broke. We can see what tests fail on Jenkins and also give QE a build for testing too.

jquick-axway · 2017-08-08T18:07:30Z

@garymathews, I understand that. I am okay with us "compiling" with the API Level 26 SDK. My point is that we should not "target" API Level 26 by default yet, because targeting it is what triggers the breaking changes. And we don't officially support API Level 26 until the breaking changes have been resolved.

However, I am okay with allowing developers (us and customers) to opt-in to targeting API Level 26 at their own risk by doing the below. This is what we should do for the moment for internal testing.

<ti:app xmlns:ti="http://ti.appcelerator.org">
	<android xmlns:android="http://schemas.android.com/apk/res/android">
		<manifest>
			<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="26"/>
		</manifest>
	</android>
</ti:app>

garymathews · 2017-08-11T15:06:52Z

@jquick-axway Gotcha, I've amended the android/package.json to reflect that. Target Android SDK 25, max supported Android SDK 26.

jquick-axway · 2017-08-11T18:52:32Z

android/package.json

-		"android sdk": ">=23 <=25.x",
-		"android build tools": ">=23 <=25.x",
-		"android platform tools": ">=17 <=25.x",
+		"android sdk": ">=25 <=26.x",


Setting the "android sdk" max to 26.x will still make Titanium target API Level 26 by default if it's installed. This is what needs to be 25.x for the time being.

I remember talking to Chris Barber about this for the following change to ensure Titanium 6.x wouldn't target API Level 25 by default, but still allow users to target it at their own risk.
jquick-axway@a80cb33

Question: Is there a reason we need to bump up the min target API Level we support from 23 to 25? I'm not opposed to it. Just curious.

Ah, I'll update the PR.

I guess we could leave it at 23, I wanted to keep it inline with our support library.

jquick-axway · 2017-08-11T18:58:15Z

android/package.json

-		"android platform tools": ">=17 <=25.x",
+		"android sdk": ">=25 <=26.x",
+		"android build tools": ">=25 <=26.x",
+		"android platform tools": ">=25 <=26.x",


Since we're including v26 of the Google supports libraries, I believe the min API level needs to be 26 for "android build tools" and "android platform tools"... or else a compiler error will occur... right? A compiler error might happen because the v26 libraries may reference new API Level 26 resources.

I don't think so, I've used 25.0.3 build tools before without issues. Not sure about the platform tools version though. I'll check that

jquick-axway · 2017-08-11T19:04:45Z

android/package.json

 		"node": ">=4.0 <=7.x",
-		"java": "<=1.8.x"
+		"java": ">=1.8.x"


Question:
Our "node scons.js build" command currently compiles our core Java code using Java version 1.6, regardless of what's installed. It would be nice if we can bump it up to Java 1.7 so that we can support new Java features such as the try-with-resource blocks and Closeable interfaces...
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html

Do you happen to know where in our CLI or build scripts this is controlled. We can make this a separate PR I suppose, but since we're now requiring a higher JDK version here, this might be a good opportunity to use newer Java features. :)

That should be here if you want to test 1.7

jquick-axway · 2017-08-11T19:06:31Z

android/package.json

 		"android tools": "<=26.x",
-		"android ndk": ">=r8e <=r9",
+		"android ndk": ">=r11c <=r15c",


Regarding Android NDK version, we have to watch out for C++ ABI compatibility issues with our precompiled V8 library. This is to avoid compiler errors and might impact hyper loop. We can figure this out later. (This is more of a warning.)

Yes, the min should be r11c, our master branch should be compatible with r15c with the new V8 update PR. So lets keep this in mind when we backport to 6_2_X

jquick-axway

CR: Pass

lokeshchdhry · 2017-08-16T22:30:58Z

@garymathews , when I try to build an app with a sdk built for this PR I get errors:

[INFO] :   Running AAPT: /Users/lchoudhary/Desktop/android-sdk-macosx/build-tools/26.0.1/aapt "package" "-f" "-m" "-J" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/gen" "-M" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/AndroidManifest.xml" "-A" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/bin/assets" "-S" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/res" "-I" "/Users/lchoudhary/Desktop/android-sdk-macosx/platforms/android-25/android.jar" "-F" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/bin/app.ap_" "--output-text-symbols" "/Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/intermediates/bundles" "--no-version-vectors" "--auto-add-overlay" "--extra-packages" "ti.modules.titanium.ui:android.support.v7.appcompat:android.support.v7.cardview:android.support.design:android.support.compat"
[ERROR] :  Failed to package application:
[ERROR] :  
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/res/values-v26/values-v26.xml:15: error: Error: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.
[ERROR] :  
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2016/ZXYZ/build/android/res/values-v26/values-v26.xml:19: error: Error: No resource found that matches the given name: attr 'android:keyboardNavigationCluster'.

If I target android 26 then it build fine.

garymathews · 2017-08-17T14:36:17Z

@lokeshchdhry Updated PR, try now? Also make sure the default generated Android manifest has android:targetSdkVersion="25"

lokeshchdhry · 2017-08-17T22:38:58Z

@garymathews, In the androidManifest I see <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="26"/>

garymathews · 2017-08-18T12:24:40Z

@lokeshchdhry Remove

<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="26"/>

from your tiapp.xml, it should default to

<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="25"/>

in the generated AndroidManifest.xml

lokeshchdhry · 2017-08-18T17:57:42Z

@garymathews , My bad the app had targetSDK as 26.

lokeshchdhry · 2017-08-18T18:03:07Z

FR Passed.

App builds fine with support library 26.0.1. No crash etc is seen.
The real verification will be done in this PR #9278 but this PR needs to be merged first.

Studio Ver: 4.9.1.201707200100
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.3
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1
Emulator: Android 4.4.4

garymathews added android improvement labels Aug 3, 2017

garymathews added this to the 7.0.0 milestone Aug 3, 2017

garymathews requested a review from jquick-axway August 3, 2017 18:46

garymathews mentioned this pull request Aug 4, 2017

[TIMOB-24503] Android: Implement notification quick actions #9278

Merged

garymathews mentioned this pull request Aug 11, 2017

[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

Merged

garymathews force-pushed the TIMOB-24967 branch from 3e14c9d to 4c12285 Compare August 11, 2017 15:04

jquick-axway reviewed Aug 11, 2017

View reviewed changes

jquick-axway approved these changes Aug 14, 2017

View reviewed changes

garymathews force-pushed the TIMOB-24967 branch 2 times, most recently from 013b509 to 26389b6 Compare August 16, 2017 15:42

garymathews changed the title ~~[TIMOB-24967] Android: Update to support library 26.0.0~~ [TIMOB-24967] Android: Update to support library 26.0.1 Aug 16, 2017

garymathews added the in-qe-testing 🕵 label Aug 16, 2017

Gary Mathews added 5 commits August 17, 2017 15:33

[TIMOB-24967] Update to support library 26.0.0

aaaa9af

[TIMOB-24967] Include IntelliJ/Android Studio project files

cb54479

[TIMOB-24967] Update Android package.json

f117d83

[TIMOB-24967] Update to support library revision 26.0.1

95e5f16

[TIMOB-24967] Specify compileSdkVersion

8978ac2

garymathews force-pushed the TIMOB-24967 branch from ef31039 to 8978ac2 Compare August 17, 2017 14:33

garymathews mentioned this pull request Aug 18, 2017

[6_2_X][TIMOB-24967] Android: Update to support library 26.0.1 #9333

Merged

Merge branch 'master' into TIMOB-24967

94b0d6b

lokeshchdhry merged commit af4da32 into tidev:master Aug 18, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-24967] Android: Update to support library 26.0.1 #9274

[TIMOB-24967] Android: Update to support library 26.0.1 #9274

garymathews commented Aug 3, 2017 •

edited

garymathews commented Aug 4, 2017

jquick-axway commented Aug 4, 2017

garymathews commented Aug 8, 2017

jquick-axway commented Aug 8, 2017

garymathews commented Aug 11, 2017 •

edited

jquick-axway Aug 11, 2017

garymathews Aug 11, 2017

jquick-axway Aug 11, 2017

garymathews Aug 11, 2017

jquick-axway Aug 11, 2017 •

edited

garymathews Aug 11, 2017

jquick-axway Aug 11, 2017

garymathews Aug 11, 2017

jquick-axway left a comment

lokeshchdhry commented Aug 16, 2017 •

edited

garymathews commented Aug 17, 2017

lokeshchdhry commented Aug 17, 2017

garymathews commented Aug 18, 2017 •

edited

lokeshchdhry commented Aug 18, 2017

lokeshchdhry commented Aug 18, 2017

[TIMOB-24967] Android: Update to support library 26.0.1 #9274

[TIMOB-24967] Android: Update to support library 26.0.1 #9274

Conversation

garymathews commented Aug 3, 2017 • edited

garymathews commented Aug 4, 2017

jquick-axway commented Aug 4, 2017

garymathews commented Aug 8, 2017

jquick-axway commented Aug 8, 2017

garymathews commented Aug 11, 2017 • edited

jquick-axway Aug 11, 2017

Choose a reason for hiding this comment

garymathews Aug 11, 2017

Choose a reason for hiding this comment

jquick-axway Aug 11, 2017

Choose a reason for hiding this comment

garymathews Aug 11, 2017

Choose a reason for hiding this comment

jquick-axway Aug 11, 2017 • edited

Choose a reason for hiding this comment

garymathews Aug 11, 2017

Choose a reason for hiding this comment

jquick-axway Aug 11, 2017

Choose a reason for hiding this comment

garymathews Aug 11, 2017

Choose a reason for hiding this comment

jquick-axway left a comment

Choose a reason for hiding this comment

lokeshchdhry commented Aug 16, 2017 • edited

garymathews commented Aug 17, 2017

lokeshchdhry commented Aug 17, 2017

garymathews commented Aug 18, 2017 • edited

lokeshchdhry commented Aug 18, 2017

lokeshchdhry commented Aug 18, 2017

garymathews commented Aug 3, 2017 •

edited

garymathews commented Aug 11, 2017 •

edited

jquick-axway Aug 11, 2017 •

edited

lokeshchdhry commented Aug 16, 2017 •

edited

garymathews commented Aug 18, 2017 •

edited