Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25051] fix persistentObjects leak #9276

Merged
merged 7 commits into from Nov 14, 2017
Merged

Conversation

drauggres
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-25051

var handle1 = new PersistentHandle({'foo': 'first'});
var handle2 = new PersistentHandle({'foo': 'second'});
handle1.dispose(); 
handle2.dispose(); // here was leak;  persistentObjects:  [ { foo: 'second' } ]

@garymathews garymathews modified the milestones: 6.2.0, 7.0.0 Aug 4, 2017
@garymathews garymathews self-requested a review August 4, 2017 11:21
@sgtcoolguy
Copy link
Contributor

CR LGTM 👍
I assume you're doing an FR/testing @garymathews ?

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FT: PASS

@build
Copy link
Contributor

build commented Oct 3, 2017

Messages
📖

🎉 Another contribution from our awesome community member, drauggres! Thanks again for helping us make Titanium SDK better. 👍

Generated by 🚫 dangerJS

@mukherjee2
Copy link
Contributor

FR Passed.

@eric34 eric34 merged commit 69b548f into tidev:master Nov 14, 2017
@drauggres drauggres deleted the TIMOB-25051 branch January 15, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants