[TIMOB-23495] iOS: Add Ti.Filesystem.File "parent" property (parity) #9285
Conversation
| var file = Ti.Filesystem.getFile('app.js'); | ||
| // parent may be null if at root? | ||
| //should(file.parent).be.ok; // not null or undefined. should(file).not.be.null causes a stack overflow somehow. | ||
| should(file).have.a.readOnlyProperty('parent'); |
There was a problem hiding this comment.
I'd assume we'd also want to verify the value is another Ti.Filesystem.File (and is a directory). Also that at some level you can't get a parent object and get null back if you try to go up a level above the app root or whatever the directory tree sandbox happens to be.
apidoc/Titanium/Filesystem/File.yml
Outdated
| @@ -176,19 +176,6 @@ methods: | |||
| if this object doesn't identify a directory. | |||
| returns: | |||
| type: Array<String> | |||
| - name: getParent | |||
There was a problem hiding this comment.
I assume we actually need to deprecate this and not just remove it? Can we have a parent property that holds a Ti.Filesystem.File return value, but also have a getParent() method that returns the path of the parent as a String?
This is a breaking change, so we need to deprecate for one major version first... I assume there are apps out there relying on this getter existing and returning a string.
There was a problem hiding this comment.
I only removed it because the getter is generated automatically by using - (NSString *)parent. But I assume we could match Android's behavior here whereby getParent returns a file and parent a string. @infosia how does Windows behave here? Although I don't like that the getter of a property returns something different (oddly, I'd rather match the most-useful behavior). Maybe deprecate the difference on Android?
| @@ -29,45 +29,44 @@ -(id)initWithFile:(NSString*)path_ | |||
| return self; | |||
| } | |||
|
|
|||
| -(void)dealloc | |||
| - (void)dealloc | |||
| { | |||
| RELEASE_TO_NIL(fm); | |||
| RELEASE_TO_NIL(path); | |||
There was a problem hiding this comment.
@hansemannn Can you Fix Indentation. I think you need to lint the file.
hansemannn
force-pushed
the
TIMOB-23495
branch
from
4dd5326
to
d93978a
Compare
| return [path stringByDeletingLastPathComponent]; | ||
| } | ||
|
|
||
| - (TiFilesystemFileProxy *)parent | ||
| { | ||
| return [[[TiFilesystemFileProxy alloc] initWithFile:[path stringByDeletingLastPathComponent]] autorelease]; |
There was a problem hiding this comment.
@sgtcoolguy Sorry to bug you on this, but to confirm:
- Deprecate
getParent()for parity with other platforms - Introduce
parentproperty that works the same across all platforms - In 8.0.0+, remove the manual
getParentaccessor, sogetParent()will use the computed getter that matches all platforms without a deprecation.
| should(file).have.a.readOnlyProperty('parent'); | ||
| should(file.parent).not.be.undefined; | ||
| should(file.getParent).not.be.undefined; | ||
| should(file.getParent.be.a.Function; |
There was a problem hiding this comment.
@hansemannn ')' is missing in above line. Please update.
|
@vijaysingh-axway Updated |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23495