Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_2_X][TIMOB-18872] Android: Icon and logo not working for ActionBar #9291

Merged
merged 1 commit into from Aug 9, 2017

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Aug 9, 2017

@ypbnv ypbnv added this to the 6.2.0 milestone Aug 9, 2017
@ypbnv ypbnv requested a review from garymathews August 9, 2017 09:12
@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Aug 9, 2017

FR Passed.
icon & 'logo` are displayed as expected.

var win = Ti.UI.createWindow({
    navBarHidden: false
});
var actionBar;
 
win.addEventListener("open", function() {
    if (Ti.Platform.osname === "android") {
        if (! win.activity) {
            Ti.API.error("Can't access action bar on a lightweight window.");
        } else {
            actionBar = win.activity.actionBar;
            if (actionBar) {
                actionBar.icon = "images/icon.png";
                actionBar.homeButtonEnabled = true;
                actionBar.subtitle = 'hello';
                actionBar.displayHomeAsUp = true; 
                actionBar.title = "New Title";
                actionBar.onHomeIconItemSelected = function() {
                    alert("Home icon clicked!");
                };
            }
        }
    }
});

win.open();
Studio Ver: 4.9.1.201707200100
SDK Ver: 6.2.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.3
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1
Emulator: Android 4.4.2

@lokeshchdhry lokeshchdhry merged commit 21ccbb7 into tidev:6_2_X Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants