[TIMOB-25003] iOS: Deprecate Ti.UI.iOS.Toolbar in favor of cross-platform Ti.UI.Toolbar #9292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphone/Classes/TiUIToolbar.m
Outdated
| * Licensed under the terms of the Apache Public License | ||
| * Please see the LICENSE included with this distribution for details. | ||
| */ | ||
| #ifdef USE_TI_UIIOSTOOLBAR |
There was a problem hiding this comment.
It should be -
+#ifdef USE_TI_UITOOLBAR
iphone/Classes/TiUIToolbar.h
Outdated
| @@ -1,24 +1,25 @@ | |||
| /** | |||
| * Appcelerator Titanium Mobile | |||
| * Copyright (c) 2009-2010 by Appcelerator, Inc. All Rights Reserved. | |||
| * Copyright (c) 2009-2017 by Appcelerator, Inc. All Rights Reserved. | |||
| * Licensed under the terms of the Apache Public License | |||
| * Please see the LICENSE included with this distribution for details. | |||
| */ | |||
|
|
|||
| #ifdef USE_TI_UIIOSTOOLBAR | |||
There was a problem hiding this comment.
It should be -
+#ifdef USE_TI_UITOOLBAR
There was a problem hiding this comment.
Actually, we should use #if defined(USE_TI_UIIOSTOOLBAR) || defined(USE_TI_UITOOLBAR) all around the place, since Ti.UI.iOS.Toolbar will invoke TiUIToolbarProxy internally as well.
apidoc/Titanium/UI/Toolbar.yml
Outdated
|
|
||
| - name: borderTop | ||
| summary: If `true`, a border is drawn on the top of the toolbar. | ||
| summary: If `true`, a border is drawn on the top of the toolbar. This property is ignored on iOS 7 and above. |
There was a problem hiding this comment.
As this property do not have effect in iOS 7 and above and we are supporting iOS 8 and above, deprecate it .
There was a problem hiding this comment.
Removed all border-related docs, since the property does not even exist in the core anymore. Good catch, keeps it clean!
apidoc/Titanium/UI/Toolbar.yml
Outdated
| - name: borderBottom | ||
| summary: If `true`, a border is drawn on the bottom of the toolbar. | ||
| summary: If `true`, a border is drawn on the bottom of the toolbar. This property is ignored on iOS 7 and above. |
|
@vijaysingh-axway Updated PR! |
hansemannn
force-pushed
the
TIMOB-25003
branch
from
369f6b0
to
2f30fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25003
Also clang-formatted the new source and made the deprecated API reuse the new one by subclassing it. Test-cases in JIRA: