[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

garymathews · 2017-08-11T14:44:29Z

~~REQUIRES #9274 TO BE MERGED~~

Implement Titanium.Android.NotificationChannel

TEST CASE

var win = Ti.UI.createWindow({title: 'TIMOB-250045', layout: 'vertical'}),
    btn = Ti.UI.createButton({title: 'CREATE NOTIFICATION', height: 50, width: Ti.UI.FILL}),
    id = 100,
    channel = Ti.Android.NotificationManager.createNotificationChannel({
        id: 'my_channel',
        name: 'TEST CHANNEL',
        importance: Ti.Android.IMPORTANCE_DEFAULT
    });

btn.addEventListener('click', function() {
    var n = Ti.Android.createNotification({
            icon: Ti.Android.R.drawable.ic_dialog_info,
            contentTitle: 'TITLE',
            contentText : 'This is a test',
            channelId: channel.getId()
        });
    Ti.Android.NotificationManager.notify(id, n);
});

win.add([btn]);
win.open();

JIRA Ticket

hansemannn

Few docs-questions!

hansemannn · 2017-08-11T15:23:16Z

apidoc/Titanium/Android/Android.yml

+        Used with [NotificationChannel](Titanium.Android.NotificationChannel) to specify an importance level.
+    type: Number
+    permission: read-only
+


since: "7.0.0" for all of these? Or is it scheduled for 6.2.0?

hansemannn · 2017-08-11T15:24:01Z

apidoc/Titanium/Android/NotificationChannel.yml

+
+  - name: vibratePattern
+    summary: The vibration pattern for notifications posted to this channel.
+    type: Array


Array of what?

hansemannn · 2017-08-11T15:24:22Z

apidoc/Titanium/Android/NotificationManager/NotificationManager.yml

+    osver: {android: {min: "8.0"}}
+    description: |
+        Create a notification channel.
+    parameters:


Does not need multi-line-wrapping, but it's no big deal.

hansemannn · 2017-08-22T08:34:50Z

@garymathews Jenkins is failing because of docs-issues:

[ERROR] ./Titanium/Android/NotificationChannel.yml
Titanium.Android.NotificationChannel: found 2 error(s)!
	Required property "summary" not found
	properties
		id
			Invalid array element: creation-only; possible values: read-only,write-only,read-write

[ERROR] ./Titanium/Android/NotificationManager/NotificationManager.yml
Titanium.Android.NotificationManager: found 1 error(s)!
	methods
		createNotificationChannel
			Required property "summary" not found

jquick-axway · 2017-08-25T22:33:29Z

android/titanium/src/java/org/appcelerator/titanium/TiC.java

 	public static final String PROPERTY_ENABLE_RETURN_KEY = "enableReturnKey";

 	/**
 	 * @module.api
 	 */
+	public static final String PROPERTY_ENABLE_VIBRATION = "enableVibrations";


The property string is set to "enableVibrations" with an 's', but you document this property without an 's'. This is a typo, right?

jquick-axway · 2017-08-25T22:35:06Z

apidoc/Titanium/Android/NotificationChannel.yml

+    type: Boolean
+
+  - name: description
+    summary: user visible description of this channel.


Capitalize "user" in sentence.

jquick-axway · 2017-08-25T22:39:33Z

apidoc/Titanium/Android/NotificationChannel.yml

+    type: Boolean
+
+  - name: vibratePattern
+    summary: The vibration pattern for notifications posted to this channel.


We should document how this array of numbers work. I believe each array element is a duration in milliseconds, right? Where the even indexed elements (ex: 0, 2, 4, 6, etc.) is the vibration time and the odd indexed elements are how long to wait between vibrations.

jquick-axway · 2017-08-25T22:42:27Z

apidoc/Titanium/Android/NotificationChannel.yml

+
+  - name: lockscreenVisibility
+    summary: Whether or not notifications posted to this channel are shown on the lockscreen in full or redacted form.
+    type: Number


We should define constants for the "lockscreenVisibility" property:
VISIBILITY_PRIVATE = 0
VISIBILITY_PUBLIC = 1
VISIBILITY_SECRET = -1

Or at least document what numbers are supported.

jquick-axway · 2017-08-25T22:43:43Z

apidoc/Titanium/Android/NotificationChannel.yml

+    type: Number
+
+  - name: id
+    summary: The channel id specified for the notification channel.


Indicate that this is a unique string ID defined by the Titanium developer.

jquick-axway · 2017-08-25T22:44:24Z

apidoc/Titanium/Android/NotificationManager/NotificationManager.yml

+    summary: Create a notification channel.
+    parameters:
+      - name: parameters
+        summary: Properties to set on a new object, including any defined by <Titanium.Android.NotificationChannel> except those marked not-creation or read-only.


Document that this function will return null on Android OS version older than Android 8.

garymathews · 2017-09-22T17:32:25Z

@jquick-axway Updated PR

build · 2017-09-22T17:55:29Z

	Fails
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

jquick-axway

CR: Pass

lokeshchdhry · 2017-11-15T21:52:12Z

FR Passed.

Notification channel works as expected along with its properties.
If ran on below android 8.0 it will throw runtime error which is expected :

[ERROR] :  [Nexus 5] TiExceptionHandler: (main) [107728,120517] ----- Titanium Javascript Runtime Error -----
[ERROR] :  [Nexus 5] TiExceptionHandler: (main) [0,120517] - In /app.js:15,32
[ERROR] :  [Nexus 5] TiExceptionHandler: (main) [0,120517] - Message: Uncaught TypeError: Cannot read property 'getId' of null
[ERROR] :  [Nexus 5] TiExceptionHandler: (main) [1,120518] - Source:             channelId: channel.getId()
[ERROR] :  [Nexus 5] V8Exception: Exception occurred at /app.js:15: Uncaught TypeError: Cannot read property 'getId' of null

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10
Appc CLI: 6.3.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.7
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel XL --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1

garymathews added android feature labels Aug 11, 2017

garymathews added this to the 7.0.0 milestone Aug 11, 2017

garymathews force-pushed the TIMOB-25045 branch from a4e75cf to e0eaa9c Compare August 11, 2017 14:46

hansemannn requested changes Aug 11, 2017

View reviewed changes

garymathews force-pushed the TIMOB-25045 branch from e0eaa9c to 8f9f3cd Compare August 21, 2017 12:20

garymathews requested a review from jquick-axway August 21, 2017 12:24

garymathews mentioned this pull request Aug 21, 2017

[6_2_X][TIMOB-25045] Implement Ti.Android.NotificationChannel #9336

Closed

garymathews force-pushed the TIMOB-25045 branch 3 times, most recently from 3c5700f to 4eb0e78 Compare August 22, 2017 15:06

jquick-axway suggested changes Aug 25, 2017

View reviewed changes

garymathews force-pushed the TIMOB-25045 branch 3 times, most recently from f790134 to 64a5595 Compare September 22, 2017 17:32

jquick-axway approved these changes Sep 22, 2017

View reviewed changes

garymathews force-pushed the TIMOB-25045 branch from 4cb9950 to 9cf49ec Compare November 13, 2017 22:20

build added android docs labels Nov 13, 2017

Gary Mathews added 3 commits November 15, 2017 13:24

[TIMOB-25045] Implement Ti.Android.NotificationChannel

c4346e8

[TIMOB-25045] Update documentation

fecc689

[TIMOB-25045] Fix vibratePattern property

444f444

garymathews force-pushed the TIMOB-25045 branch from d0cf1fd to 444f444 Compare November 15, 2017 21:42

build added the android label Nov 15, 2017

build added the docs label Nov 15, 2017

Lokesh Choudhary and others added 2 commits November 15, 2017 15:20

Merge branch 'master' into TIMOB-25045

1fc68ed

Merge branch 'master' into TIMOB-25045

c630d9b

eric34 merged commit e7387a4 into tidev:master Nov 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

garymathews commented Aug 11, 2017 •

edited

hansemannn left a comment

hansemannn Aug 11, 2017

hansemannn Aug 11, 2017

hansemannn Aug 11, 2017

hansemannn commented Aug 22, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

jquick-axway Aug 25, 2017

garymathews commented Sep 22, 2017

build commented Sep 22, 2017 •

edited

jquick-axway left a comment

lokeshchdhry commented Nov 15, 2017

[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

[TIMOB-25045] Android: Implement Ti.Android.NotificationChannel #9305

Conversation

garymathews commented Aug 11, 2017 • edited

TEST CASE

hansemannn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hansemannn commented Aug 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garymathews commented Sep 22, 2017

build commented Sep 22, 2017 • edited

jquick-axway left a comment

Choose a reason for hiding this comment

lokeshchdhry commented Nov 15, 2017

garymathews commented Aug 11, 2017 •

edited

build commented Sep 22, 2017 •

edited