Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25158] Android: Fix TableView.rightImage size #9312

Merged
merged 4 commits into from Aug 15, 2017

Conversation

garymathews
Copy link
Contributor

  • Fix Titanium.UI.TableView.rightImage size calculation
TEST CASE
var win = Ti.UI.createWindow({title: 'TIMOB-25158', backgroundColor: 'white'}),
    section = Ti.UI.createTableViewSection(),
    table = Ti.UI.createTableView({
        data: [section]
    });

section.add(Ti.UI.createTableViewRow({
    leftImage: 'http://bit.ly/2hXQ8cl',
    rightImage: 'http://bit.ly/2hXQ8cl'
}));

win.add(table);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 7.0.0 milestone Aug 14, 2017
@garymathews garymathews requested a review from ypbnv August 14, 2017 13:37
@garymathews garymathews changed the title [TIMOB-25158] Fix TableView.rightImage size [TIMOB-25158] Android: Fix TableView.rightImage size Aug 14, 2017
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Image was the correct size on both sides of the tableView.

Test Steps

  • Downloaded the SDK Build from this PR
  • Created a new Titanium project
  • Used the following test case
var win = Ti.UI.createWindow({title: 'TIMOB-25158', backgroundColor: 'white'}),
    section = Ti.UI.createTableViewSection(),
    table = Ti.UI.createTableView({
        data: [section]
    });

section.add(Ti.UI.createTableViewRow({
    leftImage: 'http://garymathews.com/icon128.png',
    rightImage: 'http://garymathews.com/icon128.png'
}));

win.add(table);
win.open();
  • Ran the application
  • Changed run-on-main-thread to false
    <property name="run-on-main-thread" type="bool">false</property>
  • Saw image size was correct on both sides of the tableView.

Test Environment
Appcelerator Command-Line Interface, version 6.2.3
Google Nexus 6P (7.1.1)
Operating System Name: Mac OS X El Capitan
Operating System Version: 10.11.6
Node.js Version: 6.10.1
Xcode: 8.2
Appcelerator Studio: 4.9.0.201705302345

@ssjsamir ssjsamir merged commit 2e3b11d into tidev:master Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants