[TIMOB-25173] Android: Modified layouts to behave more like iOS. #9320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed Android to resolve Size/Fill layout conflicts like iOS and Windows. * Note: Only an issue if parent uses Ti.UI.SIZE and child uses Ti.UI.FILL. * Android used to shrink the parent to fit the min size allowed by the child. * Now increases the size of the child to fill the parent's parent, like iOS/Windows. - Fixed horizontal layouts where views using FILL width would wrongly wrapped to next row. * Only an issue if another view is already in the row. (Resulting FILL width was too big.) - Fixed layouts to prioritize size defined by view's top/left/bottom/right/center properties over FILL and SIZE. * Only applies if at least 2 coordinate properties were provided. * Now matches iOS' behavior. - Constrained child view width to parent's max width like iOS when using wrapping horizontal views. - This commit also resolves the following layout issues: * TIMOB-12996 * TIMOB-15097 * TIMOB-17628 * TIMOB-17984 * TIMOB-19536 * TIMOB-19598 * TIMOB-19814
|
There is a new horizontal wrapping bug with views using Ti.UI.SIZE where they are constrained by the parent's remaining width instead of the parent's full width. This was discovered while testing with PR #9073 test case. We've also discovered an issue where the child view's left/center/right properties are not being used to calculate its width within a horizontal layout. iOS does this, but Android does not. This is not a new bug (existed before my code changes). I plan on adding fixes for the above to this PR in the near future. |
…t/right/top/bottom/center properties to work like iOS. - Now supports setting view width/height based on position properties relative to parent's remaining space. - Also fixed horizontal wrapping regression introduced in last commit. * Views using Ti.UI.SIZE were wrongly using row's remaing space instead of view's desired width.
|
The 2 issues have been fixed. @mukherjee2, can you resume testing please? |
mukherjee2
approved these changes
Aug 22, 2017
mukherjee2
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
https://jira.appcelerator.org/browse/TIMOB-25173
Also resolves the following JIRA cases...
Summary:
Tests:
HorizontalFillTest.jsHorizontalPinningTest.jsListViewFillTest.jsSizeFillConflictTest.jsVerticalFillTest.js