[TIMOB-25176] Fix node 4 compatibility #9322
Conversation
ewanharris
changed the title
| @@ -5,8 +5,9 @@ | |||
| * See the LICENSE file for more information. | |||
| */ | |||
|
|
|||
| const | |||
| appc = require('node-appc'), | |||
There was a problem hiding this comment.
@sgtcoolguy Wondering if that format was expected with eslint and may be in other files as well.
There was a problem hiding this comment.
Sorry, this is my super old coding style. It's bad. Nowadays I specify const or let per variable.
There was a problem hiding this comment.
+1 On each variable declaration being separate, as always there's a rule for that but not sure whether all teams would buy in to having that in the config. There's also a rule for strict mode which imo if our min ver will be node 4 should be added to the config (again doubt all times would buy in though)
There was a problem hiding this comment.
So I think we can still do per-project overrides, or additional rules on top of the common config. I'd agree that the "strict": "safe" rule is probably a good one to turn on while Node 4 is our min supported Node.
Personally, I like having multiple const/var/let` declarations combined.
|
I merged this, added the eslint rule to our .eslintrc - as well as tweaked the |
JIRA: https://jira.appcelerator.org/browse/TIMOB-25176
This PR add node 4 compatibility back, I only added 'use strict' to the files we distribute, so files in apidoc/, build/ and Gruntfile.js will still break on node 4.
If we want that it's just a matter of me running the relevant jscodemod again so no biggy, just let me know