Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25186] Android: Validate Ti.UI.Label onTouchEvent #9340

Merged
merged 3 commits into from Aug 23, 2017
Merged

[TIMOB-25186] Android: Validate Ti.UI.Label onTouchEvent #9340

merged 3 commits into from Aug 23, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 22, 2017 •
edited

  • Validate layout in Ti.UI.Label onTouchEvent
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'white'}),
    lbl = Ti.UI.createLabel({
        color: 'blue',
        text: 'https://www.appcelerator.com/',
        autoLink: Ti.UI.AUTOLINK_ALL
    });

win.add(lbl);
win.open();

JIRA Ticket

@garymathews garymathews added this to the 7.0.0 milestone Aug 22, 2017
@garymathews garymathews mentioned this pull request Aug 22, 2017
Merged
jquick-axway
jquick-axway approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ssjsamir ssjsamir requested review from ssjsamir and removed request for ssjsamir August 22, 2017 20:01
@mukherjee2 mukherjee2 self-requested a review August 23, 2017 21:53
mukherjee2
mukherjee2 approved these changes Aug 23, 2017
View reviewed changes
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. Details are in PR-9341

@mukherjee2 mukherjee2 merged commit ed80274 into tidev:master Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukherjee2 mukherjee2 mukherjee2 approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @mukherjee2 @jquick-axway @ssjsamir