Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_2_X][TIMOB-25186] Validate Ti.UI.Label onTouchEvent #9341

Merged
merged 2 commits into from Aug 23, 2017

Conversation

garymathews
Copy link
Contributor

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@mukherjee2 mukherjee2 self-requested a review August 23, 2017 21:50
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.3
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0 PR/9341
Appcelerator Studio, build: 4.9.1.201707200100
Android Devies 7.1.2, 4.4.4

Passed FR. I tried on two phones:
Android 7.1.2: I was not able to reproduce the crash on the affected version. I did not see any crashes with the 6.2.0 fixVersion. I tried 200 times with each version.
Android 4.4.4 : I tried approximately 200 times with 6.2.0 and did not see any crashes. With 6.1.2.GA, I did see a crash after about 50 tries. I then tried another 300 times on 6.1.2.GA but did not see a crash. Although I was not able to consistently reproduce the issue on the affected version, I did not see any crash on the 6.2.0 fixVersion.

@mukherjee2 mukherjee2 merged commit 499e1d7 into tidev:6_2_X Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants