[TIMOB-25188] Preserve file permissions for platform folder content #9344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvennemann
force-pushed
the
TIMOB-25188
branch
from
36698ce
to
55df544
Compare
ewieberappc
approved these changes
Aug 23, 2017
There was a problem hiding this comment.
FR Passed using:
MacOS 10.12.6 (16G24b)
Studio 4.9.0.201705302345
Ti SDK 6.2.0.v20170823144824
Appc NPM 4.2.9
Appc CLI 6.2.3
Alloy 1.9.13
Xcode 8.3.3 (8E3004b)
Execute permissions are present on frameworks in packaged modules. Tested using the provided module project and by adding additional frameworks to it for building.
cb1kenobi
approved these changes
Aug 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25188
Optional Description:
In preparation for dynamic frameworks in modules it is important to store the correct file permissions in the .zip file. This ensures the extracted framework binaries have the +x flag set that is required by
swift-stdlib-toolto properly detect Swift usage.