[TIMOB-24958] Update to windowslib@0.5.4 #9349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
force-pushed
the
TIMOB-24958
branch
from
ca08cb2
to
7afba64
Compare
infosia
approved these changes
Aug 24, 2017
|
I don't think there's any defined process for testing the updates to windowslib. I'd say maybe merge this and then it can be tested once the SDK build has been produced, Jenkins only produces an OSX version of the SDK anyway. |
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24958
Update to windowslib@0.5.4 to support winappdeploycmd detection in latest windows SDKs, also updates package-lock.json with changes from the node-titanium-sdk updates