New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-20557](6_2_X) Allow modules to use third party dynamic libraries #9351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvennemann
changed the title
[TIMOB-20557] Allow modules to use third party dynamic libraries
[TIMOB-20557](6_2_X) Allow modules to use third party dynamic libraries
Aug 23, 2017
janvennemann
force-pushed
the
TIMOB-20557-6_2_X
branch
from
August 24, 2017 12:50
9c67c3a
to
7021f3a
Compare
janvennemann
force-pushed
the
TIMOB-20557-6_2_X
branch
from
August 25, 2017 12:45
a53114c
to
61b201b
Compare
@cb1kenobi @hansemannn can you please CR this one? Thanks. |
@mukherjee2 The feedback was discussed in the master PR, @janvennemann addressed all review-feedback from @cb1kenobi 4 days ago, so once he approves master, this one should be fine as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20557
Optional Description:
6_2_X backport of #9346