Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25184] Android: Fix TableView row duplication on Android API 23+ #9363

Merged
merged 1 commit into from Aug 28, 2017

Conversation

garymathews
Copy link
Contributor

  • Fix TableView row duplication on Android 7.0 and above
TEST CASE
var win = Ti.UI.createWindow(),  
    section = Ti.UI.createTableViewSection(),
    table = Ti.UI.createTableView({
    	top: 10,
    	height: Ti.UI.FILL,
    	Width: Ti.UI.FILL,
	  	data: [section]
	});
 
createRows();
	
function createRows(){
	for(var i=0; i<=49; i++){
		var row = Ti.UI.createTableViewRow({ title: 'Open Window'+i+' - '+i});
		section.add(row);
	}
	return section;
}
 
table.addEventListener('click', function(e){
	alert(JSON.stringify(e.index));
});
 
win.add(table);
win.open();
  • All rows should be in ascending order

JIRA Ticket

@garymathews garymathews added this to the 7.0.0 milestone Aug 28, 2017
@garymathews garymathews requested a review from ypbnv August 28, 2017 00:16
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR:Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

TableView row duplication does not occur on API 23+.

Studio Ver: 4.9.1.201707200100
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.3
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1
Emulator: Android 8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants