[TIMOB-19154]: iOS9 Deprecate NSURLConnection and replace with NSURLSession API #9366
Conversation
Generated by 🚫 dangerJS |
|
@hansemannn This now has a conflict due to the PR #9619 - not sure if that means some of this fix has already been "snuck in"? This ticket was marked 7.0.0... |
|
The APS PR: tidev/APSHTTPClient#40 |
|
appcelerator.https module PR: tidev/appcelerator.https#46 |
|
@sgtcoolguy We decided to move it out of 7.0.0 due to other fixes being prioritized. The merge-conflict comes from #9612, so I just need to rebase using that revision. |
|
@hansemannn ping again 😄 |
|
@sgtcoolguy I talked to Vijay last week. It needs passing unit-tests before going further in the review. |
| @@ -20,6 +20,7 @@ typedef NS_ENUM(NSInteger, APSRequestError) { | |||
| @protocol APSConnectionDelegate <NSURLConnectionDelegate, NSURLSessionDelegate, NSURLSessionDataDelegate> | |||
| @optional | |||
| -(BOOL)willHandleChallenge:(NSURLAuthenticationChallenge *)challenge forConnection:(NSURLConnection *)connection; | |||
There was a problem hiding this comment.
This should not be required anymore. Also delegates like NSURLConnectionDelegate should be replaced. Please make sure to test all Ti.Network.HTTPClient API's in your unit-tests and ensure the old ones work without adjustments.
# Conflicts: # iphone/Classes/APSHTTPClient/libAPSHTTPClient.a
|
Test-Cases: https://gist.github.com/hansemannn/5021f0aaf2bcbe5ed054449912f3b92b (EDIT by Hans: Moved the test-case to a gist to save some scroll-time here :-) |
|
FR Passed. Tested using all of the sample and referenced tickets in the issue ticket as well as the module examples and http test suite |
https://jira.appcelerator.org/browse/TIMOB-19154