New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-24808] Implement autofill hints for TextField and TextArea #9368
Conversation
1a246a7
to
222ba30
Compare
222ba30
to
acdff8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS approved! Will wait for #9429 to be merged before, otherwise IS_XCODE_9
will not be available for testing it. Please also do a backport of the latest changes, I've commited one more change.
@hansemannn #9429 has now been merged, are we back porting to |
@garymathews Agreed, we are good to go. |
FR Passed for Android. After app launch Studio Ver: 4.10.0.201709271713 |
Humm..
|
39c1e7d
to
055a52d
Compare
055a52d
to
f2b7807
Compare
@lokeshchdhry, can you also test this with an Android 4.x device please? On Android, this feature is only supported on Android 8 and higher, so, this is to verify that this feature no-ops and we properly guard against its usage on older OS versions. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass for Android
Generated by 🚫 dangerJS |
@garymathews This ticket should be a good candidate for unit-tests to validate the |
I have added this in
Nothing happens. Whats going wrong? Additional: |
Titanium.UI.TextField
andTitanium.UI.TextArea
autofillType
for iOS and AndroidTEST CASE
JIRA Ticket