Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25206] Fix TiApplication activity type #9371

Merged
merged 3 commits into from Aug 30, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 30, 2017

  • Fix TiBaseActivity return type in TiApplication
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'gray'});

win.addEventListener('open', function(e) {
    alert('is window activity current activity? ' + (e.source.getActivity() === Ti.Android.currentActivity));
});

win.open();

TIMOB-25206
TIMOB-20037

@garymathews garymathews added this to the 7.0.0 milestone Aug 30, 2017
@garymathews garymathews requested a review from ypbnv August 30, 2017 11:03
@mukherjee2 mukherjee2 self-requested a review August 30, 2017 16:35
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node Version: 6.10.3
NPM Version: 3.10.10
Mac OS: 10.12.4
Appc CLI: 6.2.3
Appc CLI NPM: 4.2.9
Titanium SDK version: 6.2.0.v20170830085903
Appcelerator Studio, build: 4.9.1.201707200100
Xcode 8.3.2
Android OS 7.1.2
Android phones: Pixel

Passed FR. Alert showed window activity as current activity as "true". I tried it on the affected version 6.1.2 where I expected false, and indeed I saw a false. FR passed. CR passed by Yordan in PR-9372

@mukherjee2 mukherjee2 merged commit fa09758 into tidev:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants