[TIMOB-25210] Added support for the new ios-marketing app icon. #9377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
approved these changes
Aug 30, 2017
ewieberappc
approved these changes
Aug 30, 2017
|
@hans @ewieberappc Adding this logic doesn't work when only supporting the iphone device family by setting ipad to false. Due to the fact that the build is not equal to universal it will hit a positive expression on line https://github.com/appcelerator/titanium_mobile/pull/9377/files#diff-f430483233aa01af5b10df8390f9635dR4931 and gets deleted from the array. In that case you won't be able to successfully publish to the app store. |
|
@jvandijk Doh, good catch! Reopening ticket and fixing. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25210