Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25212] Android: Fix strict equality of apiName #9383

Merged
merged 3 commits into from Nov 2, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Aug 31, 2017

  • eslint changes in 86e1e2f6 included a strict equality which broke the generated module bootstrap.js
  • Although the module will build it will fail to load in a Titanium application
E/TiExceptionHandler: (main) [601,601] ----- Titanium Javascript Runtime Error -----
E/TiExceptionHandler: (main) [0,601] - In ti.touchid/bootstrap.js:28,7
E/TiExceptionHandler: (main) [0,601] - Message: Uncaught SyntaxError: Unexpected token =
E/TiExceptionHandler: (main) [0,601] - Source: 	var  =  lazyGet(this, "ti.touchid.TouchidModule", "", "");


TEST CASE
  • Build and attempt to load module in a Titanium application

JIRA Ticket

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lokeshchdhry
Copy link
Contributor

FR Passed.

  1. Built SDK with the fix.
  2. Updated ti.paint module to work with 7.0.0.
  3. Built the module with the SDK with the fix.
  4. Used the module in an app & built using 7.0.0 for android device.

No runtime error is seen as mentioned in the ticket.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10
Appc CLI: 6.3.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.7
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 89d66ec into tidev:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants