Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25220] Android: Fix FileProxy compatibility with TiDrawableReference #9392

Merged
merged 1 commit into from Sep 5, 2017
Merged

[TIMOB-25220] Android: Fix FileProxy compatibility with TiDrawableReference #9392

merged 1 commit into from Sep 5, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Sep 4, 2017 •
edited

  • Fix FileProxy compatibility with TiDrawableReference
  • Caused by 9ccebb2
TEST CASE
var win = Ti.UI.createWindow({backgroundColor: 'white'}),
    file = Ti.Filesystem.getFile('DefaultIcon.png'),
    img = Ti.UI.createImageView({image: file});

win.add(img);
win.open();

JIRA Ticket

@garymathews garymathews changed the title [TIMOB-25220] Fix FileProxy compatibility with TiDrawableReference [TIMOB-25220] Android: Fix FileProxy compatibility with TiDrawableReference Sep 4, 2017
@garymathews garymathews added this to the 7.0.0 milestone Sep 4, 2017
@garymathews garymathews mentioned this pull request Sep 4, 2017
Merged
ypbnv
ypbnv approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry lokeshchdhry self-assigned this Sep 5, 2017
@lokeshchdhry
Copy link
Contributor

FR Passed.

The file (image) is displayed properly as expected.

Studio Ver: 4.9.1.201707200100
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.4-9
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.11.2
Java Ver: 1.8.0_101
Devices: Nexus 5 -- Android 6.0.1, Pixel -- Android 7.1.1
Emulator: Android 4.4.2

@lokeshchdhry lokeshchdhry merged commit c95ca3b into tidev:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees

@lokeshchdhry lokeshchdhry

Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @lokeshchdhry @ypbnv