[TIMOB-17964] Add custom error message for wrong theme used. #9396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymathews
suggested changes
Sep 5, 2017
| try { | ||
| this.setSupportActionBar(((Toolbar) ((TiToolbarProxy) activityProxy.getProperty(TiC.PROPERTY_SUPPORT_TOOLBAR)).getToolbarInstance())); | ||
| } catch (RuntimeException e) { | ||
| Log.e(TAG, customToolbarExceptionMessage); |
There was a problem hiding this comment.
Since the error message will only be used once, it's best to just define it here
Log.e(TAG, "Attempting to use Toolbar as ActionBar without disabling the default ActionBar in the current theme.\n" +
"You must set 'windowActionBar' to false in your current theme. Or use one of the following themes:\n" +
"[Theme.Titanium, Theme.AppCompat.Translucent.NoTitleBar, Theme.AppCompat.NoTitleBar]\n" +
"Which have ActionBar disabled by default.");I have also re-worded it 👍
There was a problem hiding this comment.
Can we do a list of theme instead of []? :-)
Remove variable.
|
@garymathews , @hansemannn Updated PR. |
Generated by 🚫 dangerJS |
hansemannn
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-17964
Description:
Show a custom error message whenever a theme without disabled ActionBar is used with Toolbar acting as ActionBar.