Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25221] Android: Fixed vertical/composite layout regression caused by [TIMOB-25173] fix. #9403

Merged
merged 2 commits into from Sep 7, 2017
Merged

[TIMOB-25221] Android: Fixed vertical/composite layout regression caused by [TIMOB-25173] fix. #9403

merged 2 commits into from Sep 7, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Sep 6, 2017 •
edited

JIRA:
https://jira.appcelerator.org/browse/TIMOB-25221

Also Resolves:
https://jira.appcelerator.org/browse/TIMOB-25222
https://jira.appcelerator.org/browse/TIMOB-25223

Tests:

  • Run the following test apps attached to TIMOB-25221 and verify that the results match the "good" screenshots.
    • CompositePinningTest.js
    • VerticalPinningTest.js
  • Run the customer code added to the "Description" on TIMOB-25221 and verify the results match the 6.1.2.GA screenshot.
  • Run the TIMOB-25223 code and verify that an activity indicator is displayed at the center of the screen and the screen is dimmed.
  • Run the following test apps attached to TIMOB-25174 and verify that the results match the "good" screenshots. (To verify no new regressions are created.)
    • HorizontalFillTest.js
    • HorizontalPinningTest.js
    • ListViewFillTest.js
    • SizeFillConflictTest.js
    • VerticalFillTest.js

@jquick-axway
[TIMOB-25221] Android: Fixed vertical/composite layout regression cau…
06480ee 
…sed by [TIMOB-25173] fix.

- Fixed bug where "top" and "bottom" properties were wrongly setting view height while the "height" property was already set.
- Fixed bug where "left" and "right" properties were wrongly setting view width while the "width" property was already set.
- Fixed bug where composite layout was wrongly applying a "remaining height" calculation to subsquent added views.
  * Only applies to vertical and horizontal layouts.
@jquick-axway jquick-axway added this to the 7.0.0 milestone Sep 6, 2017
This was referenced Sep 6, 2017
Merged
Closed
garymathews
garymathews approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS
FT: PASS

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Sep 7, 2017 •
edited

FR Passed.

Executed above mentioned tests & layout seems to work as expected.

Studio Ver: 4.9.1.201707200100
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.4-9
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.13
Node Ver: 6.11.2
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.4.2

@lokeshchdhry lokeshchdhry merged commit a1de7cf into tidev:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @lokeshchdhry @garymathews