[TIMOB-25259] Android: Use ContentProvider to obtain image preview

[garymathews]

• Use TiFileProvider to obtain the Uri for the image preview for compatibility with Android 7.0+

TEST CASE

<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>

var win = Ti.UI.createWindow({backgroundColor: 'grey'}),
    btn = Ti.UI.createButton({title : 'SCREENSHOT'});

btn.addEventListener('click', function() {
    Ti.Media.takeScreenshot(function(image) {
        if (image && image.media) {
            var tmp = Ti.Filesystem.getFile(Ti.Filesystem.externalStorageDirectory, 'temp.png');

            tmp.write(image.media);
            Ti.API.info('temp file: ' + tmp.resolve());

            Ti.Media.previewImage({
                success : function() {
                    Ti.API.info('preview success');
                },
                error : function(e) {
                    alert('preview failed: ' + e.message);
                    Ti.API.error(e.message);
                },
                image : tmp.read()
            });
        } else {
            alert('failed to obtain screenshot');
        }
    });
});

win.add(btn);
win.open();

NOTE: Also test this on KitKat (4.4) and below devices, there could be a separate issue writing to external storage. But I do not have a device with 4.4 to verify this.

JIRA Ticket

[jquick-axway]

CR: Pass

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

[jquick-axway]

The getNativeFile() method can return null if:

• The photo came from the cloud.
• The image was loaded from a blob. (Can test with View.toImage().)

Calling getNativeFile() will crash with a NullPointerException for the above case too unless my code changes from PR #9223 gets merged in. (Required fixes to TitaniumBlob and TiBlob.)

Ideally, we should store the image to a temp file if it's in pure blob form before previewing it.

[jquick-axway]

We can make this a separate bug-fix/PR if you want, because it looks like the issue I mentioned was always there.

[garymathews]

Yeah, this should be a separate issue

[jquick-axway]

Okay. I just wrote up a ticket with a reproducible case here...
https://jira.appcelerator.org/browse/TIMOB-25619

[jquick-axway]

CR: Pass

[lokeshchdhry]

FR Passed.

No exposed beyond app through Intent.getData() seen on API 24 & above.
Tested on 7.1.1, 6.0.1 & 4.4.4.

Studio Ver: 5.0.0.201712081732
SDK Ver: 7.1.0 local build
OS Ver: 10.13.2
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.11
Appc CLI: 7.0.1
Daemon Ver: 1.0.1
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.10
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

[lokeshchdhry]

@garymathews , Can you please add tests.