[TIMOB-24805] (6_3_X) iOS11: Support large window titles #9431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysingh-axway
approved these changes
Sep 14, 2017
There was a problem hiding this comment.
CR Passed.
Note for QE - Please verify it after merging #9430 , as IS_XCODE_9 macro is defined there.
# Conflicts: # iphone/Classes/TiUIWindowProxy.m
# Conflicts: # iphone/Classes/TiUIiOSProxy.h # Conflicts: # iphone/Classes/TiUIiOSProxy.h
# Conflicts: # iphone/Classes/TiUIiOSProxy.h
hansemannn
force-pushed
the
TIMOB-24805-6_3_X
branch
from
d0cabbd
to
e9f191b
Compare
ssjsamir
approved these changes
Oct 11, 2017
There was a problem hiding this comment.
FR Passed: Was able to see a large window title when largeTitleDisplayMode: Ti.UI.iOS.LARGE_TITLE_DISPLAY_MODE_ALWAYSwas used.
Test Steps:
- Created a new titanium project
- Added the code from the description in to the project
- Ran the application from studio
- Saw window had a large title
largeTitleDisplayMode: Ti.UI.iOS.LARGE_TITLE_DISPLAY_MODE_ALWAYS
- Saw that title was no longer large
Test Environment
Appcelerator Command-Line Interface, version 6.2.4
iPhone 7 emulator (11.0)
iphone 5S plus 11.0.3
Operating System Name: Mac OS High Sierra
Operating System Version: 10.13
Node.js Version: 6.10.1
Xcode: 9.0
Appcelerator Studio: 4.10.0.201709271713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24805