New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25266] Android: Fix WebView HW-acceleration for Android 4.1 #9432
Conversation
@@ -73,7 +73,6 @@ public WebViewProxy() | |||
defaultValues.put(TiC.PROPERTY_OVER_SCROLL_MODE, 0); | |||
defaultValues.put(TiC.PROPERTY_LIGHT_TOUCH_ENABLED, true); | |||
defaultValues.put(TiC.PROPERTY_ENABLE_JAVASCRIPT_INTERFACE, true); | |||
defaultValues.put(TiC.PROPERTY_BORDER_RADIUS, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that this border radius zero line was added to resolve an HTML5 video issue (see PR #8681). Do we need to re-test this? Or have you confirmed that this issue was resolved somewhere else, like in TiUIView?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has already been resolved.
|| d.containsKeyAndNotNull(TiC.PROPERTY_BORDER_RADIUS) | ||
|| d.containsKeyAndNotNull(TiC.PROPERTY_BORDER_WIDTH); | ||
return d.containsKeyAndNotNull(TiC.PROPERTY_BORDER_WIDTH) | ||
&& d.getDouble(TiC.PROPERTY_BORDER_WIDTH) > 0f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we still need to do an -or- check to see if radius is > 0f
because it'll "clip" the view with rounded corners, even if the border width is zero, right?
ad19a81
to
48b2bd5
Compare
@jquick-axway Good catch! Updated PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
FR Passed. Loading url in a webview does not crash the app on Android 4.1 Studio Ver: 4.10.0.201709271713 |
Titanium.UI.WebView
when aborderWidth
is definedhasBorder()
to only betrue
when aborderWidth
andborderRadius
is definedNOTE: I found anomalies when attempting to play HTML5 content back with HW-acceleration enabled and a border defined
TEST CASE #1
TEST CASE #2
JIRA Ticket