Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25288]Android: addAnnotations in Ti.Map crashes app #9442

Merged
merged 2 commits into from Sep 19, 2017

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Sep 18, 2017

JIRA: https://jira.appcelerator.org/browse/TIMOB-25288

Description:
Bundled module looks for non-existing method. Rebuild against latest sources.
Attached Module archive should be added as a release version.

Test case:
In JIRA ticket.

ti.map-android-3.3.1.zip

@ypbnv ypbnv added this to the 7.0.0 milestone Sep 18, 2017
@garymathews
Copy link
Contributor

garymathews commented Sep 18, 2017

@ypbnv I added a 3.3.1 pre-release compiled with 6.2.0.GA to ti.map

This makes the support/module/packaged/modules.json link valid (https://github.com/appcelerator-modules/ti.map/releases/download/android-3.3.1/ti.map-android-3.3.1.zip).

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

Ran the test code from the ticket to check if adding annotations outside createView does not crash the app.

Studio Ver: 4.9.1.201707200100
SDK Ver: 6.2.0.GA
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.4
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.14
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Map Module: 3.3.1
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@ypbnv
Copy link
Contributor Author

ypbnv commented Sep 19, 2017

@garymathews Thank you!

@hansemannn hansemannn merged commit 75640ff into tidev:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants