Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25323] Android: Release V8Object when KrollRuntime is alive #9460

Merged
merged 3 commits into from Nov 2, 2017
Merged

[TIMOB-25323] Android: Release V8Object when KrollRuntime is alive #9460

merged 3 commits into from Nov 2, 2017

Conversation

garymathews
Copy link
Contributor

  • Only release V8Objects when KrollRuntime is alive

JIRA Ticket

@garymathews garymathews added this to the 7.0.0 milestone Sep 20, 2017
jquick-axway
jquick-axway approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented Oct 30, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫

Tests have failed, see below for more information.

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient clearCookieUnaffectedCheck 60.039 Error: timeout of 60000ms exceeded

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

  1. Built an app with the fix.
  2. Launched the app.
  3. Closed using the back button.
  4. Launch the app again.
  5. Close using the back button.

No crash seen after few seconds of closing the app.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10
Appc CLI: 6.3.0
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.7
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@build build added the android label Nov 2, 2017
@sgtcoolguy sgtcoolguy merged commit 8fe28a2 into tidev:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @jquick-axway @sgtcoolguy