Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25332] (6_3_X) iOS 11: Fix table-view estimated heights #9466

Merged
merged 2 commits into from Sep 25, 2017
Merged

[TIMOB-25332] (6_3_X) iOS 11: Fix table-view estimated heights #9466

merged 2 commits into from Sep 25, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
[TIMOB-25332] Fix table-view estimated heights
858cc03 
# Conflicts:
#	iphone/Classes/TiUIListView.m
#	iphone/Classes/TiUITableView.m
@hansemannn hansemannn added this to the 6.3.0 milestone Sep 22, 2017
vijaysingh-axway
vijaysingh-axway approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@hansemannn
Copy link
Collaborator Author

@sgtcoolguy I tried adding unit-tests as well, but as it's an internal change / behavior fix, there are no modified, added or removed API's. Technically, we could detect those by grep'ing for two things:

  • - (void)set<API>:
  • valueForKey:
  • objectForKey:
  • - (id/NSString/NSArray/NSNumber/NSDate/NSDictionary) <- Regex?

In 90 % of the cases, this will detect any new getter or setter applied to the SDK. Unfortunately I am not familiar with writing regex's so far, so that might be a good task to exercise. Do you think it would make sense to apply that to the Dangerfile and file a ticket for it or are there cases where this could fall through?

@ewieberappc ewieberappc self-requested a review September 25, 2017 18:23
ewieberappc
ewieberappc approved these changes Sep 25, 2017
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. No odd spacing or UI oddities witnessed when using or modifying a listview. Tested using the provided code as well as the ListView test suite.

@ewieberappc ewieberappc merged commit 35114bc into tidev:6_3_X Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewieberappc ewieberappc ewieberappc approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @ewieberappc @vijaysingh-axway