[TIMOB-25334] iOS: Prevent Ti.UI.TableView & Ti.UI.ListView from sliding up in navigation-window #9470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
FR Passed. ListViews and TableViews do not slide when opened from or opening a nav window. Tested using the provided sample code and KitchenSink v2. |
rlustemberg
added a commit
to rlustemberg/titanium_mobile
that referenced
this pull request
Sep 27, 2017
* commit 'ac2eccd028534a485fc1887696753097b488e35b': (721 commits) [TIMOB-25347] Fix Ti.UI.Android.DrawerLayout layout (tidev#9477) titanium_ui_drawer_layout.xml fixes: background, elevation and fitsSystemWindows (tidev#9439) [TIMOB-25334] iOS: Prevent Ti.UI.TableView & Ti.UI.ListView from sliding up in navigation-window (tidev#9470) [TIMOB-25318] Fixed bug where sim builds were blowing up when incorrectly trying to access the provisioning profile. (tidev#9473) [TIMOB-25318] Improved team-id auto-selection and allow the team-id t… (tidev#9468) Fix typo in dangerfile for handling test failures [TIMOB-25332] Fix table-view estimated heights First try at reporting failed tests in the Danger.JS PR comment. Fix clang-format warnings Wipe the workspace of the node running S3 publishing (Deploy stage) afterwards. Also wipe the dist/ dir before unarchiving. This should prevent retaining old build artifacts. [TIMOB-25318] Fixed typos, consolidated regexp, and improved method name. [TIMOB-25318] Improved provisioning profile validation to check against the cert. Ignore junit reports in git If first build on a mainline branch, trigger Windows SDK build after done Wrap clone of test suite into try/catch block and explicitly warn if we fail that most likely cause is that the target branch doesn't exist. Fix list of files stashes for danger.js Try to fix post-build Danger stage. Need to stash/unstash files since we likely have changed nodes Move running Danger.JS to last stage for PRs only. Add more danger checks. Fix eslint warnings Don't pre-set build status to 'SUCCESS' - causes us to mark PR as good when git checkout step is done, which is BAD ... # Conflicts: # iphone/Classes/TiApp.h # iphone/Classes/TiApp.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25334