[TIMOB-25287] (6_3_X): iPhone X - Ti.UI.SearchBar in list-view get wrongly positioned #9482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
changed the title
hansemannn
approved these changes
Oct 2, 2017
|
@hansemannn Can you review last commit please. It is simpler solution. As we are setting contentInsetAdjustmentBehavior property of tableView UIScrollViewContentInsetAdjustmentNever, similarly setting searchTableView property will fix the problem . No need to adjusting using safeAreaInsets. Thanks! |
|
Will do! Please rebase the whole PR to the base-branch and only add the new lines. Right now, the PR still has changes to the indentation caused by the master PR. Ideally, the PR should only have 6 lines changed (2 if-statements with the content-insets change). |
|
Rather rebasing I restored indentation, which fixes previously existing spaces etc also. Though there are few more lines addition and deletion, I think it will be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25287