[TIMOB-18441] Add --sigalg option on cli for overriding keystore signing algorithm.
#9484
Conversation
…gning algorithm.
|
I'm fine with this feature, but this CLI option needs to be explicitly declared so that it shows up in the help, must have validation, and must have a default value. |
|
@cb1kenobi Ok, I will update soon! |
| @@ -878,6 +878,12 @@ AndroidBuilder.prototype.config = function config(logger, config, cli) { | |||
| order: 120, | |||
| required: true, | |||
| values: _t.targets | |||
| }, | |||
| 'sigalg': { | |||
There was a problem hiding this comment.
Can you please add a default property with a value of 'MD5withRSA' so that it signifies the default value in the help screen.
There was a problem hiding this comment.
Done! Thank you :)
There was a problem hiding this comment.
Oh boy, I messed up. Specifying a default will properly show the correct default in the help screen, but then this.sigalg will always have a value and it never falls back to the auto-detected this.keystoreAlias.sigalg.
My apologies. Please remove the default value.
There was a problem hiding this comment.
Oh! It's really easy thing. I have committed. Thank you for your kind review. 👍
| @@ -878,6 +878,12 @@ AndroidBuilder.prototype.config = function config(logger, config, cli) { | |||
| order: 120, | |||
| required: true, | |||
| values: _t.targets | |||
| }, | |||
| 'sigalg': { | |||
There was a problem hiding this comment.
Oh boy, I messed up. Specifying a default will properly show the correct default in the help screen, but then this.sigalg will always have a value and it never falls back to the auto-detected this.keystoreAlias.sigalg.
My apologies. Please remove the default value.
|
Looks great! Thank you very much! |
JIRA: https://jira.appcelerator.org/browse/TIMOB-18441
Optional Description:
ti build -p android -T dist-playstore --sigalg SHA1withRSAThis is a very simple changes.
But, sometimes this is necessary.
Therefore, this is no reason not to provide.
Thank you.