Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25358]:iOS Problem with Searchbar, SDK 6.2.0 and later #9495

Merged
merged 17 commits into from Oct 11, 2017
Merged

[TIMOB-25358]:iOS Problem with Searchbar, SDK 6.2.0 and later #9495

merged 17 commits into from Oct 11, 2017

Conversation

vijaysingh-axway
Copy link
Contributor

hansemannn
hansemannn requested changes Oct 2, 2017
View reviewed changes
iphone/Classes/TiUITableView.m Outdated
while (tempView != viewController.view) {
leftMargin += tempView.frame.origin.x;
topMargin += tempView.frame.origin.y;
tempView = tempView.superview;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the padding is 100px, you are re-assigning a UIView instance a hundred times. We cannot use a while-loop for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The while loop will run as many times as many superview are there till its window containing controller's view are found. So it will not run 100 times for a padding of 100px. Rather it will run for as many super views make it 100px. resultViewController is presented on window holding controller, so we have to calculate this padding.

hansemannn
hansemannn reviewed Oct 2, 2017
View reviewed changes
iphone/Classes/TiUIListView.m
@@ -2154,10 +2154,17 @@ - (void)presentSearchController:(UISearchController *)controller
[viewController presentViewController:controller
animated:NO
completion:^{
CGPoint convertedOrigin = [self.superview convertPoint:self.frame.origin toView:viewController.view];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so the proposal worked?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :)

@sgtcoolguy sgtcoolguy added the ios label Oct 2, 2017
@build
Copy link
Contributor

build commented Oct 4, 2017 •
edited

Fails
🚫

Tests have failed, see below for more information.
Warnings
⚠️

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code

Tests:

Classname Name Time Error
ios.Titanium.Database execute() returns null instead of empty result set 0.007 file:///Users/build/Library/Developer/CoreSimulator/Devices
ios.Titanium.Locale #getString(String, String) with default/hint value 0.045 [native code]
file:///Users/build/Library/Developer/CoreSimulator/D

Generated by 🚫 dangerJS

@hansemannn hansemannn merged commit aa8f184 into tidev:master Oct 11, 2017
@hansemannn hansemannn mentioned this pull request Oct 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vijaysingh-axway @build @hansemannn @sgtcoolguy @ewieberappc