[TIMOB-25358](6_3_X):iOS Problem with Searchbar, SDK 6.2.0 and later #9496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
requested changes
Oct 3, 2017
iphone/Classes/TiUITableView.m
Outdated
| @@ -1639,7 +1639,8 @@ -(void)updateSearchView | |||
|
|
|||
| if (tableHeaderView == nil) | |||
| { | |||
| CGRect wrapperFrame = CGRectMake(0, 0, [tableview bounds].size.width, TI_NAVBAR_HEIGHT); | |||
| CGFloat wrapperHeight = [TiUtils isIOS11OrGreater] ? 56.0 : 44.0; | |||
There was a problem hiding this comment.
No hardcoded Values please.
There was a problem hiding this comment.
You mean I should use macro for same similar to previous implementation ?
There was a problem hiding this comment.
Yep. Or if possible get the height from the actual parent frame. Hardcoded values are the worst, we should try to avoid it at any time.
…358_6_3_X # Conflicts: # iphone/Classes/TiUIListView.m # iphone/Classes/TiUITableView.m
…358_6_3_X # Conflicts: # iphone/Classes/TiUIListView.m # iphone/Classes/TiUITableView.m
|
FR Passed. Searchbar search results correctly appear on top of the view and not shifted to the side. Tested using the test cases and the searchbar suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25358