Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25346] (6_3_X) iOS: Restore SBJSON for encoded strings #9499

Merged
merged 1 commit into from Oct 10, 2017
Merged

[TIMOB-25346] (6_3_X) iOS: Restore SBJSON for encoded strings #9499

merged 1 commit into from Oct 10, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn
[TIMOB-25346] Restore SBJSON for encoded strings
b1417dd 
# Conflicts:
#	iphone/Classes/XHRBridge.m
@hansemannn hansemannn added this to the 6.3.0 milestone Oct 2, 2017
@hansemannn hansemannn self-assigned this Oct 2, 2017
vijaysingh-axway
vijaysingh-axway approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR and FT passed.

@ewieberappc ewieberappc self-requested a review October 10, 2017 20:07
ewieberappc
ewieberappc approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@ewieberappc ewieberappc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. Able to use nested JSON payload in fireEvent without issue. Tested using provided code as well as the webview suite.

@ewieberappc ewieberappc merged commit 310a542 into tidev:6_3_X Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewieberappc ewieberappc ewieberappc approved these changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@hansemannn hansemannn

Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @ewieberappc @vijaysingh-axway