Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25266] Android: Fix WebView HW-acceleration for Android 4.1 #9507

Merged
merged 7 commits into from Oct 25, 2017
Merged

[TIMOB-25266] Android: Fix WebView HW-acceleration for Android 4.1 #9507

merged 7 commits into from Oct 25, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 7.0.0 milestone Oct 6, 2017
@build
Copy link
Contributor

build commented Oct 6, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

Loading url in a webview does not crash the app on Android 4.1

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.9
Appc CLI: 6.2.4
Ti CLI Ver: 5.0.14
Alloy Ver: 1.9.14
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Device : Android 4.1

@ypbnv ypbnv mentioned this pull request Oct 9, 2017
Merged
@jquick-axway
Copy link
Contributor

@sgtcoolguy, this change does not require a unit test update. It fixes a crash that only happens on Android 4.1. Can you merge it please?

@sgtcoolguy sgtcoolguy merged commit 15f1ee7 into tidev:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees

@lokeshchdhry lokeshchdhry

Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @lokeshchdhry @jquick-axway @sgtcoolguy