[TIMOB-25373] : iOS - Search result view of List did not close when w idow containing list view get closed #9508
Conversation
…idow containing list view get closed
| @@ -312,6 +312,11 @@ - (id)init | |||
|
|
|||
| - (void)dealloc | |||
| { | |||
| if ([searchController isActive]) { | |||
| searchController.view.hidden = YES; | |||
| [searchController setActive:NO]; | |||
There was a problem hiding this comment.
Why not remove it's delegates and nil it as well (like the others)?
There was a problem hiding this comment.
That is already there. See few lines below in this function :) . You will find -
searchController.searchResultsUpdater = nil;
searchController.delegate = nil;
RELEASE_TO_NIL(searchController);
There was a problem hiding this comment.
I see this for the list-view, but not the table-view. Am I missing a snippet?
There was a problem hiding this comment.
I think so. You can see at line 338.
There was a problem hiding this comment.
I mean list-view, I cannot see nil'ing searchResultsUpdater in TiUIListView.m.
There was a problem hiding this comment.
Ok. You are right. Done.
Generated by 🚫 dangerJS |
|
@ewieberappc Build is passing now! Merging here for consistency. |
https://jira.appcelerator.org/browse/TIMOB-25373