Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25376] Android: Fixed bug where scrolled in ListView rows forget their width/height #9517

Merged
merged 5 commits into from Oct 17, 2017
Merged

[TIMOB-25376] Android: Fixed bug where scrolled in ListView rows forget their width/height #9517

merged 5 commits into from Oct 17, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Oct 11, 2017 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-25376

Test:

  1. Run test code attached to TIMOB-25376 on Android.
  2. Scroll down to the bottom of the ListView.
  3. Verify that none of the rows have grown to the window's height. (See case's screenshots.)

@jquick-axway
[TIMOB-25376] Android: Fixed bug where scrolled in ListView rows forg…
43c0e33 
…et their width/height settings.

- This was a pre-existing issue before 6.2.0, but the layout pin fill fixes made in 6.2.0 revealed it.
- Caused by ListView calling TiUIView.processProperties() with only changed properties. Since width/height did not change, they're null. This causes processProperties() to reset LayoutParams via TiConvert.fillLayout() to do pin-fillls instead.
@jquick-axway jquick-axway added this to the 7.0.0 milestone Oct 11, 2017
@jquick-axway jquick-axway mentioned this pull request Oct 11, 2017
Merged
@build
Copy link
Contributor

build commented Oct 11, 2017 •
edited

Fails
🚫

Tests have failed, see below for more information.
Warnings
⚠️

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code

Tests:

Classname Name Time Error
android.Titanium.UI.View TIMOB-20598 5.022 Error: timeout of 5000ms exceeded
ios.Titanium.UI.View TIMOB-20598 5.072 file:///Users/build/Libra

Generated by 🚫 dangerJS

garymathews
garymathews approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

ListView rows are displayed properly & do not grow in size after scrolled.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10-2
Appc CLI: 6.3.0-master.14
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.5
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit 88c91a4 into tidev:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jquick-axway @build @lokeshchdhry @garymathews @ssjsamir