Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_3_X][TIMOB-25376] Android: Fixed bug where scrolled in ListView rows forget their width/height settings #9518

Merged
merged 1 commit into from Oct 12, 2017

Conversation

jquick-axway
Copy link
Contributor

…et their width/height settings.

- This was a pre-existing issue before 6.2.0, but the layout pin fill fixes made in 6.2.0 revealed it.
- Caused by ListView calling TiUIView.processProperties() with only changed properties. Since width/height did not change, they're null. This causes processProperties() to reset LayoutParams via TiConvert.fillLayout() to do pin-fillls instead.
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

ListView rows are displayed properly & do not grow in size after scrolled.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.3.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10-2
Appc CLI: 6.3.0-master.14
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.5
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
⇨ google Nexus 5 --- Android 6.0.1

@lokeshchdhry lokeshchdhry merged commit cafa601 into tidev:6_3_X Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants