Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6_3_X][TIMOB-25360] Android ScrollView enhancements #9521

Merged
merged 3 commits into from Oct 11, 2017
Merged

[6_3_X][TIMOB-25360] Android ScrollView enhancements #9521

merged 3 commits into from Oct 11, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Oct 11, 2017 •
edited

@jquick-axway
[TIMOB-25360] Android: ScrollView enhancements
8d33155 
- [TIMOB-25197] Added RefreshControl support to vertical and horizontal ScrollViews.
- [TIMOB-8898] Added Ti.UI.FIll and Ti.UI.SIZE support to ScrollView "contentWidth" and "contentHeight" properties.
- [TIMOB-25360] ScrollView child views that use Ti.UI.FILL should do a 100% fill like iOS if contentWidth/Height properties are not set.
- [TIMOB-25377] ScrollView child percent size/position should be relative to container size, like iOS.
  * Was relative to ScrollView's scrollable content area.
- [TIMOB-12153] ListView/TableView height set to Ti.UI.SIZE will return wrong height when put inside a ScrollView.
  * Was returning a height equivalent to Ti.UI.FILL, which was limited to size of parent view or window.
- Improved ScrollView measurement/layout performance:
  * Was always doing a 2-pass measurement, which would cause issues with percentage calculations.
  * Now only does a 1-pass mearurement.
@jquick-axway
Android: Code changes based on feedback from [TIMOB-25360] commit.
bfe13e4
@jquick-axway jquick-axway added this to the 6.3.0 milestone Oct 11, 2017
@lokeshchdhry
Copy link
Contributor

FR Passed. Used the test code in the tickets to test :

  1. https://jira.appcelerator.org/browse/TIMOB-25197 : RefreshControl works as expected in a horizontal & vertical scrollview.
  2. https://jira.appcelerator.org/browse/TIMOB-25360 : width & height set to Ti.UI.FILL is displayed in parity to IOS.
  3. https://jira.appcelerator.org/browse/TIMOB-25377 : ScrollView child with percent size are displayed as expected & fill the scrollView appropriately.
  4. https://jira.appcelerator.org/browse/TIMOB-12153 : Scrollview with a tableview does scroll as expected if contentHeight is set to auto.
  5. https://jira.appcelerator.org/browse/TIMOB-8898 : FILL behavior on contentWidth/contentHeight property of scroll view works as expected.

Studio Ver: 4.10.0.201709271713
SDK Ver: 6.3.0 Local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10-2
Appc CLI: 6.3.0-master.14
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.5
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Pixel --- Android 7.1.1
Emulator: Android 6.0.0

@lokeshchdhry lokeshchdhry merged commit 7ce9694 into tidev:6_3_X Oct 11, 2017
@hansemannn
Copy link
Collaborator

@jquick-axway Missing docs here? Also, does Alloy work with this? And should the master PR still be open?

@jquick-axway
Copy link
Contributor Author

@hansemannn

  • You're right. I forgot to update the docs. I'll do so soon.
  • Yes, this works with Alloy. I've confirmed it.
  • Several master PRs have been left open due to Jenkins unit test issues which were just resolved yesterday. QE will start merging them soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android bug improvement parity 👯‍♀️
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jquick-axway @lokeshchdhry @hansemannn