Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25300] iOS 11: Fix title-control in landscape #9522

Merged
merged 6 commits into from Nov 7, 2017
Merged

[TIMOB-25300] iOS 11: Fix title-control in landscape #9522

merged 6 commits into from Nov 7, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.0.0 milestone Oct 12, 2017
@hansemannn hansemannn self-assigned this Oct 12, 2017
@build
Copy link
Contributor

build commented Oct 12, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Oct 14, 2017
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@eric34 eric34 merged commit c3613aa into tidev:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees

@hansemannn hansemannn

Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hansemannn @build @vijaysingh-axway @eric34 @ewieberappc @mukherjee2