Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25269] iOS: Use final iPhone X launch-image names #9533

Merged
merged 8 commits into from Nov 7, 2017
Merged

[TIMOB-25269] iOS: Use final iPhone X launch-image names #9533

merged 8 commits into from Nov 7, 2017

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn added this to the 7.0.0 milestone Oct 18, 2017
@hansemannn hansemannn self-assigned this Oct 18, 2017
@build
Copy link
Contributor

build commented Oct 18, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫

Tests have failed, see below for more information.

Tests:

Classname Name Time Error
android.Titanium.Network.HTTPClient clearCookieUnaffectedCheck 60.06 Error: timeout of 60000ms exceeded

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Blocked here. Project-related logic-changes, so no new unit-tests applicable.

@hansemannn hansemannn requested review from janvennemann and removed request for cb1kenobi October 19, 2017 13:54
@sgtcoolguy
Copy link
Contributor

@hansemannn seems ok to me to merge without tests... But we need QE to test first.

@sgtcoolguy sgtcoolguy self-requested a review October 19, 2017 15:49
@sgtcoolguy sgtcoolguy removed the request for review from janvennemann October 19, 2017 15:49
@hansemannn
Copy link
Collaborator Author

Yep, @ewieberappc is on it, thanks! 🙂

cb1kenobi
cb1kenobi reviewed Oct 31, 2017
View reviewed changes
iphone/cli/commands/_build.js
@@ -3959,7 +3959,7 @@ iOSBuilder.prototype.writeInfoPlist = function writeInfoPlist() {
'name': 'Default-Landscape',
'subtype': '2436h',
'scale': [ '3x' ],
'size': '{812, 375}'
'size': '{375, 812}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would a landscape orientation have a shorter width than the height? Shouldn't it be the opposite and the previous code be correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but Eric reminded me that all others are the same. And native ones as well. I don't even think the UILaunchImages plist keys are actually used anymore.

@build build added the ios label Nov 3, 2017
@eric34 eric34 merged commit 42961ca into tidev:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi left review comments

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees

@hansemannn hansemannn

Labels
bug in-qe-testing 🕵 ios
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@hansemannn @build @sgtcoolguy @cb1kenobi @roelandp @ewanharris @eric34 @mukherjee2