[TIMOB-24765] Android: Implement Ti.UI.ShortcutItem pinning

[garymathews]

#9426 MUST BE MERGED FIRST

• Implement Titanium.UI.ShortcutItem.pin() to pin shortcuts to the launcher

TEST CASE

var win = Ti.UI.createWindow({backgroundColor: 'grey'}),
    btn = Ti.UI.createButton({title: 'PIN SHORTCUT'}),
    shortcut = Ti.UI.createShortcutItem({
        id: 'test_shortcut',
        icon: Ti.Android.R.drawable.ic_dialog_info,
        title: 'TEST',
        description: 'DESCRIPTION'
    });

Ti.App.addEventListener('shortcutitemclick', function() {
    win.backgroundColor = 'blue';
});

btn.addEventListener('click', () => {
    win.backgroundColor = 'red';
    shortcut.pin();
});

win.add(btn);
win.open();

JIRA Ticket

[build]

	Fails
🚫	😥 npm test failed. See below for details.
🚫	🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages

📖

> titanium-mobile@7.3.0 test /Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9536-D2LTM57TF7WWOTYNXXE4VBVVT7CIP4VMS4GGP2CSJIA73OQM5AVQ > grunt Running "appcJs:src:lintOnly" (appcJs) task Running "eslint:src" (eslint) task /Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9536-D2LTM57TF7WWOTYNXXE4VBVVT7CIP4VMS4GGP2CSJIA73OQM5AVQ/tests/Resources/ti.ui.maskedimage.addontest.js 27:3 warning Expected an assignment or function call and instead saw an expression no-unused-expressions 32:3 warning Expected an assignment or function call and instead saw an expression no-unused-expressions 33:3 warning Expected an assignment or function call and instead saw an expression no-unused-expressions /Users/build/jenkins/workspace/sdk_titanium_mobile_PR-9536-D2LTM57TF7WWOTYNXXE4VBVVT7CIP4VMS4GGP2CSJIA73OQM5AVQ/tests/Resources/ti.ui.picker.addontest.js 11:5 warning 'should' is assigned a value but never used no-unused-vars ✖ 4 problems (0 errors, 4 warnings) Running "checkFormat:ios" (checkFormat) task Running "checkFormat:android" (checkFormat) task Fatal error: Error: Formatting incorrect on "android/modules/ui/src/java/ti/modules/titanium/ui/ShortcutItemProxy.java", proposed changes: <?xml version='1.0'?> <replacements xml:space='preserve' incomplete_format='false'> <replacement offset='940' length='0'> </replacement> <replacement offset='941' length='0'> </replacement> <replacement offset='1961' length='6'>&#10;&#10; </replacement> <replacement offset='2671' length='0'> </replacement> <replacement offset='4211' length='4'> </replacement> </replacements> Error: Formatting incorrect on "android/titanium/src/java/org/appcelerator/titanium/TiBaseActivity.java", proposed changes: <?xml version='1.0'?> <replacements xml:space='preserve' incomplete_format='false'> <replacement offset='38108' length='1'>&#10; </replacement> </replacements> Error: Formatting incorrect on "android/titanium/src/java/org/appcelerator/titanium/TiRootActivity.java", proposed changes: <?xml version='1.0'?> <replacements xml:space='preserve' incomplete_format='false'> <replacement offset='2058' length='8'>&#10;&#10; </replacement> </replacements> � npm ERR! Test failed. See above for more details.

Generated by 🚫 dangerJS

[ypbnv]

Looks good to me!

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

[ssjsamir]

@garymathews Please could you take a look at the merge conflicts?

[lokeshchdhry]

FR Passed.

Shortcut pinning works as expected.

Studio Ver: 5.1.2.201810080801
SDK Ver: 7.5.0 local build
OS Ver: 10.14
Xcode Ver: Xcode 10.0
Appc NPM: 4.2.14-2
Appc CLI: 7.0.6
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.2
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Pixel (Android 9.0)
⇨ google Nexus 6P (Android 8.1.0)