[TIMOB-25322] (6_3_X) iOS: Improve new Ti.Geolocation authentication-flow #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed the implementation! Works as described. |
jvandijk
reviewed
Oct 20, 2017
| // (by selecting "when in use", he/she will still get a dialog that includes the "when in use" option. | ||
| // In case that one is still selected then, the developer should know about that selection and the following | ||
| // statement allows that. | ||
| if (!requestedStatusMatchesActualStatus) { |
There was a problem hiding this comment.
@hansemannn this addition has zero effect, because when the authorization status remains unchanged and thus this whole method is not fired.
There was a problem hiding this comment.
It's for the initial "when in use" instead of "always" selection, which would fire but with success: true.
ewieberappc
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25322