Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6_3_X][TIMOB-25423] Android: Ti.UI.Slider on Android 4.x is not working #9547

Merged
merged 3 commits into from Oct 26, 2017

Conversation

maggieaxway
Copy link
Contributor

Update TIUISlider.java

JIRA: https://jira.appcelerator.org/browse/TIMOB-25423

Test case:

var win1 = Titanium.UI.createWindow({
    title:'TIMOB-25423',
    backgroundColor:'#000'
});
var slider = Titanium.UI.createSlider({
     min: 0, max: 100, width: '100%', height: Ti.UI.SIZE, value: 0, splitTrack: 'true'
    });

var label = Ti.UI.createLabel({
    text: slider.value,
    width: Ti.UI.FILL,
    top: 30,
    left: 0,
    textAlign: Ti.UI.TEXT_ALIGNMENT_CENTER
});

slider.addEventListener('change', function(e) {
    label.text = e.value;
});

win1.add(slider);
win1.add(label);
win1.open();

@hansemannn
Copy link
Collaborator

@garymathews The following test-case currently fails:

  1) #isGooglePlayServicesAvailable()
    {"state":"failed","duration":1,"suite":"Titanium.Map","title":"#isGooglePlayServicesAvailable()","error":{},"stdout":"","stderr":"[WARN] : \b\b \b W/System.err: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/common/GooglePlayServicesUtil;\n[WARN] : \b\b \b W/System.err: \tat ti.map.MapModule.isGooglePlayServicesAvailable(MapModule.java:106)\n[WARN] : \b\b \b W/System.err: \tat org.appcelerator.kroll.runtime.v8.V8Function.nativeInvoke(Native Method)\n[WARN] : \b\b \b W/System.err: \tat org.appcelerator.kroll.runtime.v8.V8Function.callSync(V8Function.java:57)\n[WARN] : \b\b \b W/System.err: \tat org.appcelerator.kroll.runtime.v8.V8Function.call(V8Function.java:43)\n[WARN] : \b\b \b W/System.err: \tat ti.modules.titanium.TitaniumModule$Timer.run(TitaniumModule.java:147)\n[WARN] : \b\b \b W/System.err: \tat android.os.Handler.handleCallback(Handler.java:739)\n[WARN] : \b\b \b W/System.err: \tat android.os.Handler.dispatchMessage(Handler.java:95)\n[WARN] : \b\b \b W/System.err: \tat android.os.Looper.loop(Looper.java:148)\n[WARN] : \b\b \b W/System.err: \tat android.app.ActivityThread.main(ActivityThread.java:5417)\n[WARN] : \b\b \b W/System.err: \tat java.lang.reflect.Method.invoke(Native Method)\n[WARN] : \b\b \b W/System.err: \tat com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)\n[WARN] : \b\b \b W/System.err: \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)\n[WARN] : \b\b \b W/System.err: Caused by: java.lang.ClassNotFoundException: Didn't find class \"com.google.android.gms.common.GooglePlayServicesUtil\" on path: DexPathList[[zip file \"/data/app/com.appcelerator.testApp.testing-2/base.apk\"],nativeLibraryDirectories=[/data/app/com.appcelerator.testApp.testing-2/lib/x86, /data/app/com.appcelerator.testApp.testing-2/base.apk!/lib/x86, /vendor/lib, /system/lib]]\n[WARN] : \b\b \b W/System.err: \tat dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)\n[WARN] : \b\b \b W/System.err: \tat java.lang.ClassLoader.loadClass(ClassLoader.java:511)\n[WARN] : \b\b \b W/System.err: \tat java.lang.ClassLoader.loadClass(ClassLoader.java:469)\n[WARN] : \b\b \b W/System.err: \t... 12 more\n[WARN] : \b\b \b W/System.err: \tSuppressed: java.lang.ClassNotFoundException: com.google.android.gms.common.GooglePlayServicesUtil\n[WARN] : \b\b \b W/System.err: \t\tat java.lang.Class.classForName(Native Method)\n[WARN] : \b\b \b W/System.err: \t\tat java.lang.BootClassLoader.findClass(ClassLoader.java:781)\n[WARN] : \b\b \b W/System.err: \t\tat java.lang.BootClassLoader.loadClass(ClassLoader.java:841)\n[WARN] : \b\b \b W/System.err: \t\tat java.lang.ClassLoader.loadClass(ClassLoader.java:504)\n[WARN] : \b\b \b W/System.err: \t\t... 13 more\n[WARN] : \b\b \b W/System.err: \tCaused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack trace available\n"}

Is this resolved by your PR in #9546 ?

@jquick-axway jquick-axway changed the title [TIMOB-25423] Android: Ti.UI.Slider on Android 4.x is not working [6_3_X][TIMOB-25423] Android: Ti.UI.Slider on Android 4.x is not working Oct 24, 2017
@jquick-axway
Copy link
Contributor

@hansemannn, that test failure appears to be some kind of server issue. That is, either there is something wrong with the "ti.map" module installation or with how the build system is failing to merge the library dependencies. A unit test change won't fix it (other than to skip the "ti.map" test). We should talk about it offline with Gary and Chris Williams.

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

FR Passed.

Ti.UI.Slider does not crash on android 4.X.

Studio Ver: 4.10.0.201709271713
SDK Ver: 6.3.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10-2
Appc CLI: 6.3.0-master.15
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.6
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: Android 4.4.2

@lokeshchdhry lokeshchdhry merged commit 15ace51 into tidev:6_3_X Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants