[6_3_X][TIMOB-25437] Remove const/let usage and use strict #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garymathews
changed the title
hansemannn
approved these changes
Oct 24, 2017
mukherjee2
approved these changes
Oct 26, 2017
There was a problem hiding this comment.
Passed FR with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Appc CLI: 6.3.0-master.16
Appc CLI NPM: 4.2.10-2
Titanium SDK version: 6.3.0.v20171026142134 (artifact from this PR)
Appcelerator Studio vers 4.10.0
Xcode 9.0.1/iOS 11.0.3 iPhone 7 Plus
I first built the test app with an SDK without the fix, and saw the same error that was mentioned in the ticket. I then built the app with the SDK that has the fix, and saw no errors. The app also functioned as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25437
#9535 Was a bad fix and exposed errors due to the code now running in strict mode. This PR removes the
'use strict'and usage of const/let. If we backport any fixes in the CLI code from master we need to remember to not use const/let.Verification