Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-16257] Android: Fixed crashed caused by setting ScrollView.scrollingEnabled on non-UI thread #9550

Merged
merged 3 commits into from Oct 25, 2017

Conversation

jquick-axway
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-16257

Notes:

  • Caused by Android message ID collision with super class' IDs.
  • Also resolved potential ID collision with the following features:
    • Ti.UI.ActivityIndicator
    • Ti.UI.CardView
    • Ti.UI.Label
    • Ti.UI.Window

Test:

  1. Set up a classic app project using the below files. (Note that the app must be to not run JavaScript on the main thread.)
  2. Run the project on an Android device.
  3. Verify that the app does crash on startup.

tiapp.xml

<?xml version="1.0" encoding="UTF-8"?>
<ti:app xmlns:ti="http://ti.appcelerator.org">
    <property name="run-on-main-thread" type="bool">false</property>
</ti:app>

app.js

var scrollView = Ti.UI.createScrollView({});
scrollView.scrollingEnabled = true;

…lingEnabled on non-UI thread.

- Caused by Android message ID collision with super class' IDs.
- Also resolved potential ID collision with the following features:
  * ActivityIndicator
  * CardView
  * Label
  * Window
@build
Copy link
Contributor

build commented Oct 24, 2017

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

No crash seen when setting ScrollView.scrollingEnabled on non-UI thread.

Studio Ver: 4.10.0.201709271713
SDK Ver: 7.0.0 local build
OS Ver: 10.12.3
Xcode Ver: Xcode 8.3.3
Appc NPM: 4.2.10-2
Appc CLI: 6.3.0-master.15
Ti CLI Ver: 5.0.14
Alloy Ver: 1.10.6
Node Ver: 7.10.1
Java Ver: 1.8.0_101
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Pixel --- Android 7.1.1

@lokeshchdhry lokeshchdhry merged commit 5f826a6 into tidev:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants