Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25416] Ambiguous certificates trigger development provisioning profiles validation error 6_3_X #9554

Merged
merged 5 commits into from Oct 30, 2017

Conversation

feons
Copy link
Contributor

@feons feons commented Oct 25, 2017

@hansemannn
Copy link
Collaborator

@feons Can you resolve the merge conflicts?

@feons
Copy link
Contributor Author

feons commented Oct 30, 2017

@hansemannn, resolved.

@ewieberappc ewieberappc merged commit c0638cd into tidev:6_3_X Oct 30, 2017
@ewanharris
Copy link
Collaborator

ewanharris commented Oct 31, 2017

@feons @hansemannn We shouldn't be using const/let in the build files as we can't safely make the switch (on 6_3_X) to 'use strict'; to keep node 4 compat

@hansemannn
Copy link
Collaborator

@feons @ewieberappc Either revert or provide another PR for this? This was discovered while fixing iPhone x launch-screens for a customer that used Node 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants