[TIMOB-25346] iOS: Fix JSON-parse edge-case when sending view-proxy #9555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukherjee2
requested review from
mukherjee2
and removed request for
ewieberappc
mukherjee2
approved these changes
Oct 26, 2017
There was a problem hiding this comment.
Passed FR with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Appc CLI: 6.2.4
Appc CLI NPM: 4.2.10-2
Titanium SDK version: 6.3.0.v20171026120035 (artifact from this P/R)
Appcelerator Studio vers 4.10.0
Xcode 9.0.1/iOS 11.0.3 iPhone 7 Plus
Launched app. Clicked "Trigger". Clicked "Close". There was no crash and app functioned as expected. I tried again with older SDK (affected version), and the app gave a run-time error when I clicked "Close".
|
@hansemannn FR passed, but CR needs to be done. |
janvennemann
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25346