Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25442] Android: Updated Titanium SDK and build tools to compile with Java 7 #9562

Merged
merged 3 commits into from Nov 9, 2017

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Oct 27, 2017

JIRA:

Summary:

  • Updated core Android Titanium SDK code to use Java 7. (Was limited to Java 6.)
  • Updated CLI to build Android modules with Java 7. (Was limited to Java 6.)

Titanium SDK Java 7 Test:

  1. Build/package/install the "titanium_mobile" SDK for Android.
  2. Verify that build succeeded without any Java compiler errors. (Note that "TiApplication.java" is now using a Java 7 try-resource feature which would cause a compiler error in Java 6.)
  3. Build and run a Titanium app on Android.
  4. Observe the Android log on startup and verify that a message similar to the below gets printed on startup. (The date will match the time you compiled the SDK.)
    [INFO] : TiApplication: (main) [43,43] Titanium 7.0.0 (2017/10/26 15:22 undefined)

Module Java 7 Test:

  1. Build/package/install the "titanium_mobile" SDK for Android.
  2. Run the test described in TIMOB-25448 on Mac.
  3. Run the same test on Windows.

- [TIMOB-25442] Updated core Android Titanium SDK code to use Java 7.
- [TIMOB-25448] Updated CLI to build Android modules with Java 7.
@jquick-axway jquick-axway added this to the 7.0.0 milestone Oct 27, 2017
@jquick-axway jquick-axway changed the title [TIMOB-25442] Android: Updates Titanium SDK and build tools to compile with Java 7. [TIMOB-25442] Android: Updated Titanium SDK and build tools to compile with Java 7 Oct 27, 2017
@build
Copy link
Contributor

build commented Oct 27, 2017

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

Generated by 🚫 dangerJS

@cb1kenobi
Copy link
Contributor

CR'd and it looks good to me.

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE: Good to merge without unit test changes.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mukherjee2 mukherjee2 self-requested a review November 8, 2017 23:46
Copy link
Contributor

@mukherjee2 mukherjee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed FR with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Windows OS 10.0.14393
Appc CLI: 7.0.0-master.6
Appc CLI NPM: 4.2.11-2
Titanium SDK version: 7.0.0 / PR-9562

I followed the steps in the original ticket to reproduce, and I was able to validate the fix.

@mukherjee2
Copy link
Contributor

@sgtcoolguy can you please merge? As per @jquick-axway unit tests are not required. Thanks.

@mukherjee2 mukherjee2 removed the request for review from janvennemann November 9, 2017 17:51
@build build added the android label Nov 9, 2017
@sgtcoolguy sgtcoolguy merged commit 180972d into tidev:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants