New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25442] Android: Updated Titanium SDK and build tools to compile with Java 7 #9562
Conversation
- [TIMOB-25442] Updated core Android Titanium SDK code to use Java 7. - [TIMOB-25448] Updated CLI to build Android modules with Java 7.
Generated by 🚫 dangerJS |
CR'd and it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QE: Good to merge without unit test changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed FR with this environment:
Node Version: 6.11.5
NPM Version: 3.10.10
Mac OS: 10.13
Windows OS 10.0.14393
Appc CLI: 7.0.0-master.6
Appc CLI NPM: 4.2.11-2
Titanium SDK version: 7.0.0 / PR-9562
I followed the steps in the original ticket to reproduce, and I was able to validate the fix.
@sgtcoolguy can you please merge? As per @jquick-axway unit tests are not required. Thanks. |
JIRA:
Summary:
Titanium SDK Java 7 Test:
[INFO] : TiApplication: (main) [43,43] Titanium 7.0.0 (2017/10/26 15:22 undefined)
Module Java 7 Test: